Wt

Hi,

to fill WRasterImage with data, for example by procedurally generated content like in the Mandelbrot example or other applications image data, you need to use the WRasterImage::setPixel() method. This sets and syncs a single pixel to GraphicsImage.

What about providing another constructor that allows to set the full data on initialization using a given raw pixel pointer? I append an alternative constructor that receives a rawPixel pointer and a map parameter to specify the channel order for GraphicsMagic (see below).

Doing some measurements with the Mandelbrot example, and measuring only the time spent to set the data either pixel wise or in one step (as proposed), I gained about x10 in release and x100 in debug mode.

What do you think? If you have time, also the setter methods from GraphicsMagic to change a region could be exposed, but for me a second constructor would be fine.

Two more minor things:

- In the constructor, you convert the given type (e.g. "png") to uppercase, but this string is not used subsequently. Does not seem to harm, though.

• In your constructor, you initialize the GraphicsImage with an allocated unsigned char array, which is not used anywhere else except to initialize GraphicsImage (and to delete in the destructor, later). You could consider using GraphicsImage::AllocateImage() with the desired background color set as a parameter, instead, using less memory + overhead.

Best,

Tassilo

Proposed constructor:

WRasterImage::WRasterImage(const std::string& type,
    const WLength& width, const WLength& height,
    const unsigned char * rawPixels,
    const char* map, 
    WObject *parent )
: WResource(parent),
width_(width),
height_(height),
type_(type),
painter_(0),
currentClipPath_(-1),
currentClipPathRendered_(-1)
{
    InitializeMagick(0);

    w_ = static_cast<unsigned long>(width.toPixels());
    h_ = static_cast<unsigned long>(height.toPixels());

    context_ = 0;
    fontSupport_ = 0;

    if (!w_ || !h_) {
        pixels_ = 0;
        image_ = 0;
        return;
    }

    // only support RGBA and RGB, with all permutations, e.g., BGRA
    ImageType imageType = TrueColorMatteType;
    if (strstr(map,"A") == NULL)
    {
        imageType = TrueColorType;
    }

    ExceptionInfo exception;
    GetExceptionInfo(&exception);
    image_ = ConstituteImage(w_, h_, map, CharPixel, rawPixels, &exception);

    SetImageType(image_, imageType);
    // no opacity since we initialized with values
    SetImageOpacity(image_, 0);

    // changed this to acutally use the uppercase string
    std::string magick = type;
    std::transform(magick.begin(), magick.end(), magick.begin(), toupper);
    strcpy(image_->magick, magick.c_str());
}