Bug #6453
closedMemory leak in MySQL.C
0%
Description
In MySQL.C in function bind_output in line 822 an array of my_bool is allocated. This array is not used at all (pointers to elements are used in line 826 but overwritten by mallocs in line 879.
The local variable is destroyed without deleting the array.
Updated by Roel Standaert over 6 years ago
Are you referring to errors_? That doesn't seem to be local. It's a member of MySQLStatement and is freed in its destructor. It does seem like it's never used, indeed. I guess it was intended as an optimization so it doesn't need to do a single-char malloc for every error, but then the code mistakenly still does a malloc for every error anyway. I'll see if I can safely remove that extra malloc for every error.
Updated by Roel Standaert over 6 years ago
- Status changed from New to Resolved
I just pushed a commit that removes the extra malloc for every error field.
Updated by Olaf Bonorden over 6 years ago
You're right, sorry, I should not use a browser to look at source code in the middle of the night.
Would it be possible to also initialize the error fields before calling mysql_stmt_bind_result? Some versions of maria db do not clear the flag, leading to issue https://redmine.emweb.be/issues/6407.
Updated by Roel Standaert over 6 years ago
Yes, I also fixed that yesterday. Is there still a problem with that?
Updated by Roel Standaert about 6 years ago
- Status changed from Resolved to Closed