Project

General

Profile

Actions
Copy link

Bug #8577

closed
BT RS

test.http reports two failing tests related to trusted proxies

Bug #8577: test.http reports two failing tests related to trusted proxies

Added by Bruce Toll over 5 years ago. Updated almost 5 years ago.

Status:
Closed
Priority:
Low
Assignee:
Roel Standaert
Target version:
4.5.1
Start date:
05/24/2021
Due date:
% Done:

100%

Estimated time:

Description

With Wt 4.5.0-rc1-52-g42a5ef9f (github master), I've encountered two test failures with test.http. It may be a mistake on my part with configuration or how I'm running the tests. I've attached the test output, as well as a patch for your review that helps the tests pass in my environment.

Files

Download all files
test_http_client_address_output_4.5.0-rc1-52-g42a5ef9f.txt (2.93 KB) test_http_client_address_output_4.5.0-rc1-52-g42a5ef9f.txt Bruce Toll, 05/24/2021 09:09 PM
0001-Fix-a-couple-of-trusted-proxy-tests.patch (1.66 KB) 0001-Fix-a-couple-of-trusted-proxy-tests.patch Bruce Toll, 05/24/2021 09:09 PM

KD Updated by Korneel Dumon over 5 years ago Actions
Copy link
 #1

According to the documentation in wt_config.xml, I think it's actually the second test (for Client-IP) that should use the trusted proxy list.

BT Updated by Bruce Toll over 5 years ago Actions
Copy link
 #2

Hi Korneel,

Thanks for following-up. I think you're right. I probably should have just reported the test failures, as the intended behavior of the tests seemed somewhat ambiguous to me. Please disregard the suggested patch.

--Bruce

RS Updated by Roel Standaert over 5 years ago Actions
Copy link
 #3

  • Assignee set to Roel Standaert
  • Target version set to 4.6.0

RS Updated by Roel Standaert over 5 years ago Actions
Copy link
 #4

  • Status changed from New to InProgress

RS Updated by Roel Standaert over 5 years ago Actions
Copy link
 #5

  • Status changed from InProgress to Review

RS Updated by Roel Standaert about 5 years ago Actions
Copy link
 #6

  • Status changed from Review to Resolved

RS Updated by Roel Standaert about 5 years ago Actions
Copy link
 #7

  • % Done changed from 0 to 100

RS Updated by Roel Standaert almost 5 years ago Actions
Copy link
 #8

  • Target version changed from 4.6.0 to 4.5.1

RS Updated by Roel Standaert almost 5 years ago Actions
Copy link
 #9

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: PDF Atom