Actions
Bug #9922
closedEmpty server pushes are not properly discarded
Start date:
03/10/2022
Due date:
% Done:
100%
Estimated time:
Description
WebRenderer
has an isDirty()
function that checks whether there is any update at all. If we have no updates then triggerUpdate()
won't actually cause any updates to be pushed.
However, this doesn't work properly. It checks if collectedJS1_
is empty, and we always add an opening and closing curly brace.
A simple fix but somewhat ugly fix could be to update the check from:
!collectedJS1_.empty()
to:
!(collectedJS1_.empty() || (collectedJS1_.length() == 2 && collectedJS1_.str() == "{}"))
Updated by Roel Standaert over 2 years ago
- Status changed from New to InProgress
- Assignee set to Roel Standaert
Updated by Roel Standaert over 2 years ago
- Status changed from InProgress to Review
- Assignee deleted (
Roel Standaert)
Updated by Roel Standaert over 2 years ago
- Precedes Bug #10019: Follow up issue for issue #9922: Empty server pushes are not properly discarded added
Updated by Roel Standaert over 2 years ago
- Precedes deleted (Bug #10019: Follow up issue for issue #9922: Empty server pushes are not properly discarded)
Updated by Roel Standaert over 2 years ago
- Related to Bug #10019: Follow up issue for issue #9922: Empty server pushes are not properly discarded added
Updated by Roel Standaert over 2 years ago
- Status changed from Review to Resolved
Updated by Roel Standaert over 2 years ago
- Status changed from Resolved to Closed
Actions