Wt

There is a leak of RegistrationModel in AuthWidget. It gets created, but never

deleted. It looks like the ownership of RegistrationModel was intended to be in RegistrationView, but there are problems there too.

RegistrationView does not delete model_ in it's destructor. It does delete an existing model_ if setModel() is called more than once. That could be disasterous if the following sequence occurred:

registrationModel_ = createRegistrationModel();

w->setModel(registrationModel_);

...

w->setModel(registrationModel_);

which would cause AuthWidget::registrationModel_ to point to unallocated space.

That would promote the argument that AuthWidget should not contain a pointer to the object RegistrationModel which is passed to RegistrationView.

Unfortunately, AuthWidget::createUpdatePasswordView() also uses createRegistrationModel() so the logic for that would need to change as well.

Or since both views use the same RegistrationModel object, then ownership of that object makes more sense in AuthWidget. That would require the delete in ~AuthWidget, and removal of the delete from RegistrationView. No change to UpdatePasswordWidget would be required.

For now, my solution is to make AuthWidget::registrationModel_ protected instead of private, and have MyAuthWidget handle it appropriately.

Hey Cassie,

Same problem here, I already had a Wt fork for something else so I passed what I needed in protected.

protected: 
  AuthModel *model_;
  RegistrationModel *registrationModel_;
  Login& login_;

Maybe I am missing something, but I do not understand the "virtual" if the underlying attributes are private :)

Regards,

Thomas

Hey,

The criticism is entirely correct. I've split the function as suggested.

I'ld rather not have you have to mess in the library!

Regards,

koen