Project

General

Profile

Actions

Bug #10482

closed

Wt creates invalid HTML/CSS

Added by Steven Köhler over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Target version:
Start date:
06/12/2022
Due date:
% Done:

100%

Estimated time:

Description

I recently ran an HTML validity check and found some HTML/CSS errors which turned out to be caused by Wt:

I ran the test with one of my applications, but it can easily be reproduced with any application, like the Wt homepage: see https://validator.w3.org/nu/?doc=https%3A%2F%2Fwebtoolkit.eu. (The Wt homepage itself has some more issues, but those don't seem to be automatically generated HTML/CSS.)

  • The first two errors are caused because Wt does not recognize <link> and <meta> as self closing tags in DomElement::isSelfClosingTag.
  • The cursor: hand CSS error occurs on multiple occasions and is always preceded by cursor: pointer, and thus looks like the result of a failed find and replace operation to me.

I already fixed those errors and created a pull request for it: https://github.com/emweb/wt/pull/192. Although most browsers handle these errors pretty well, I think it is preferable to not have them in the first place.


Files

errors.png (51.6 KB) errors.png Steven Köhler, 06/12/2022 08:35 PM
Actions #1

Updated by Roel Standaert over 2 years ago

  • Status changed from New to Resolved
  • Assignee set to Steven Köhler
Actions #2

Updated by Roel Standaert over 2 years ago

  • Target version set to 4.8.0
Actions #3

Updated by Roel Standaert over 2 years ago

  • Target version changed from 4.8.0 to 4.7.3
Actions #4

Updated by Roel Standaert over 2 years ago

  • % Done changed from 0 to 100
Actions #5

Updated by Roel Standaert over 2 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF