Project

General

Profile

Actions
Copy link

Improvements #10954

closed
RS RM

Investigate suspicious fallthrough

Improvements #10954: Investigate suspicious fallthrough

Added by Roel Standaert almost 4 years ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Romain Mardulyn
Target version:
4.12.2
Start date:
09/19/2022
Due date:
% Done:

100%

Estimated time:

Description

When working on issue #10953 I marked some fallthroughs as suspicious, we should take a closer look at them to verify if these are accidental or deliberate. They are all marked with // FIXME: suspicious fallthrough, and are in:

  • src/Wt/Chart/WAbstractGridData.C: WAbstractGridData::updateGL
  • src/Wt/WTime.C: WTime::formatToRegExp
  • src/http/WtReply.C: WtReply::consumeWebSocketMessage
  • src/web/WebSession.C: WebSession::getEventType
  • src/Wt/Dbo/Query.C: Wt::Dbo::Impl::addLimitQuery

Related issues 1 (0 open — 1 closed)

Related to Improvements #10953: Explicitly mark fallthrough in switch statementsClosedRoel Standaert09/19/2022

Actions

RS Updated by Roel Standaert almost 4 years ago Actions
Copy link
 #1

  • Description updated (diff)

RS Updated by Roel Standaert almost 4 years ago Actions
Copy link
 #2

RM Updated by Romain Mardulyn over 1 year ago Actions
Copy link
 #3

  • Status changed from New to InProgress
  • Assignee set to Romain Mardulyn

RM Updated by Romain Mardulyn over 1 year ago Actions
Copy link
 #4

  • Status changed from InProgress to Review
  • Assignee deleted (Romain Mardulyn)

MV Updated by Matthias Van Ceulebroeck 10 months ago Actions
Copy link
 #5

  • Assignee set to Matthias Van Ceulebroeck
  • Target version changed from future to 4.12.2

MV Updated by Matthias Van Ceulebroeck 9 months ago Actions
Copy link
 #6

  • Status changed from Review to Implemented @Emweb
  • Assignee changed from Matthias Van Ceulebroeck to Romain Mardulyn
  • % Done changed from 0 to 100

RM Updated by Romain Mardulyn 6 months ago Actions
Copy link
 #7

  • Status changed from Implemented @Emweb to Closed
Actions
Copy link

Also available in: PDF Atom