Project

General

Profile

Actions
Copy link

Improvements #10954

open

Investigate suspicious fallthrough

Added by Roel Standaert over 2 years ago. Updated 4 months ago.

Status:
Review
Priority:
Normal
Assignee:
-
Target version:
future
Start date:
09/19/2022
Due date:
% Done:

0%

Estimated time:

Description

When working on issue #10953 I marked some fallthroughs as suspicious, we should take a closer look at them to verify if these are accidental or deliberate. They are all marked with // FIXME: suspicious fallthrough, and are in:

  • src/Wt/Chart/WAbstractGridData.C: WAbstractGridData::updateGL
  • src/Wt/WTime.C: WTime::formatToRegExp
  • src/http/WtReply.C: WtReply::consumeWebSocketMessage
  • src/web/WebSession.C: WebSession::getEventType
  • src/Wt/Dbo/Query.C: Wt::Dbo::Impl::addLimitQuery

Related issues 1 (0 open — 1 closed)

Related to Improvements #10953: Explicitly mark fallthrough in switch statementsClosedRoel Standaert09/19/2022

Actions
Actions
Copy link
 #1

Updated by Roel Standaert over 2 years ago

  • Description updated (diff)
Actions
Copy link
 #2

Updated by Roel Standaert over 2 years ago

Actions
Copy link
 #3

Updated by Romain Mardulyn 4 months ago

  • Status changed from New to InProgress
  • Assignee set to Romain Mardulyn
Actions
Copy link
 #4

Updated by Romain Mardulyn 4 months ago

  • Status changed from InProgress to Review
  • Assignee deleted (Romain Mardulyn)
Actions
Copy link

Also available in: Atom PDF