Project

General

Profile

Actions
Copy link

Improvements #10953

closed

Explicitly mark fallthrough in switch statements

Added by Roel Standaert about 2 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Roel Standaert
Target version:
4.10.0
Start date:
09/19/2022
Due date:
% Done:

100%

Estimated time:

Description

Wt should not report implicit fallthrough warnings (-Wimplicit-fallthrough). We should mark every deliberate fallthrough explicitly.

For C++17 this can be done with [[fallthrough]]. For C++14 and GCC compatible compilers (like Clang) we can
use __attribute__((fallthrough)).

Related issues 1 (1 open — 0 closed)

Related to Improvements #10954: Investigate suspicious fallthroughNew09/19/2022

Actions
Actions
Copy link
 #1

Updated by Roel Standaert about 2 years ago

  • Status changed from InProgress to Review
Actions
Copy link
 #2

Updated by Roel Standaert about 2 years ago

Actions
Copy link
 #3

Updated by Roel Standaert about 2 years ago

  • Assignee changed from Roel Standaert to Korneel Dumon
Actions
Copy link
 #4

Updated by Roel Standaert about 2 years ago

  • Target version changed from 4.9.0 to 4.10.0
Actions
Copy link
 #5

Updated by Roel Standaert about 2 years ago

  • Target version changed from 4.10.0 to 4.9.0
Actions
Copy link
 #6

Updated by Roel Standaert almost 2 years ago

  • Target version changed from 4.9.0 to 4.10.0
Actions
Copy link
 #7

Updated by Roel Standaert almost 2 years ago

  • Assignee deleted (Korneel Dumon)
Actions
Copy link
 #8

Updated by Roel Standaert almost 2 years ago

  • Assignee set to Matthias Van Ceulebroeck
Actions
Copy link
 #9

Updated by Roel Standaert almost 2 years ago

  • Status changed from Review to Implemented @Emweb
  • Assignee changed from Matthias Van Ceulebroeck to Roel Standaert
  • % Done changed from 0 to 100
Actions
Copy link
 #10

Updated by Roel Standaert almost 2 years ago

  • Status changed from Implemented @Emweb to Resolved
Actions
Copy link
 #11

Updated by Matthias Van Ceulebroeck over 1 year ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF