Project

General

Profile

Actions

Improvements #10953

closed
RS RS

Explicitly mark fallthrough in switch statements

Improvements #10953: Explicitly mark fallthrough in switch statements

Added by Roel Standaert almost 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Roel Standaert
Target version:
Start date:
09/19/2022
Due date:
% Done:

100%

Estimated time:

Description

Wt should not report implicit fallthrough warnings (-Wimplicit-fallthrough). We should mark every deliberate fallthrough explicitly.

For C++17 this can be done with [[fallthrough]]. For C++14 and GCC compatible compilers (like Clang) we can
use __attribute__((fallthrough)).


Related issues 1 (0 open1 closed)

Related to Improvements #10954: Investigate suspicious fallthroughClosedRomain Mardulyn09/19/2022

Actions

RS Updated by Roel Standaert almost 4 years ago Actions #1

  • Status changed from InProgress to Review

RS Updated by Roel Standaert almost 4 years ago Actions #2

RS Updated by Roel Standaert almost 4 years ago Actions #3

  • Assignee changed from Roel Standaert to Korneel Dumon

RS Updated by Roel Standaert almost 4 years ago Actions #4

  • Target version changed from 4.9.0 to 4.10.0

RS Updated by Roel Standaert almost 4 years ago Actions #5

  • Target version changed from 4.10.0 to 4.9.0

RS Updated by Roel Standaert over 3 years ago Actions #6

  • Target version changed from 4.9.0 to 4.10.0

RS Updated by Roel Standaert over 3 years ago Actions #7

  • Assignee deleted (Korneel Dumon)

RS Updated by Roel Standaert over 3 years ago Actions #8

  • Assignee set to Matthias Van Ceulebroeck

RS Updated by Roel Standaert over 3 years ago Actions #9

  • Status changed from Review to Implemented @Emweb
  • Assignee changed from Matthias Van Ceulebroeck to Roel Standaert
  • % Done changed from 0 to 100

RS Updated by Roel Standaert over 3 years ago Actions #10

  • Status changed from Implemented @Emweb to Resolved

MV Updated by Matthias Van Ceulebroeck over 3 years ago Actions #11

  • Status changed from Resolved to Closed
Actions

Also available in: PDF Atom