Project

General

Profile

Actions

Improvements #10953

closed

Explicitly mark fallthrough in switch statements

Added by Roel Standaert over 1 year ago. Updated 9 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Roel Standaert
Target version:
Start date:
09/19/2022
Due date:
% Done:

100%

Estimated time:

Description

Wt should not report implicit fallthrough warnings (-Wimplicit-fallthrough). We should mark every deliberate fallthrough explicitly.

For C++17 this can be done with [[fallthrough]]. For C++14 and GCC compatible compilers (like Clang) we can
use __attribute__((fallthrough)).


Related issues 1 (1 open0 closed)

Related to Improvements #10954: Investigate suspicious fallthroughNew09/19/2022

Actions
Actions #1

Updated by Roel Standaert over 1 year ago

  • Status changed from InProgress to Review
Actions #2

Updated by Roel Standaert over 1 year ago

Actions #3

Updated by Roel Standaert over 1 year ago

  • Assignee changed from Roel Standaert to Korneel Dumon
Actions #4

Updated by Roel Standaert over 1 year ago

  • Target version changed from 4.9.0 to 4.10.0
Actions #5

Updated by Roel Standaert over 1 year ago

  • Target version changed from 4.10.0 to 4.9.0
Actions #6

Updated by Roel Standaert about 1 year ago

  • Target version changed from 4.9.0 to 4.10.0
Actions #7

Updated by Roel Standaert about 1 year ago

  • Assignee deleted (Korneel Dumon)
Actions #8

Updated by Roel Standaert about 1 year ago

  • Assignee set to Matthias Van Ceulebroeck
Actions #9

Updated by Roel Standaert about 1 year ago

  • Status changed from Review to Implemented @Emweb
  • Assignee changed from Matthias Van Ceulebroeck to Roel Standaert
  • % Done changed from 0 to 100
Actions #10

Updated by Roel Standaert about 1 year ago

  • Status changed from Implemented @Emweb to Resolved
Actions #11

Updated by Matthias Van Ceulebroeck 9 months ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF