Project

General

Profile

Improvements #11001

FlexLayoutImpl: consider using gap for spacing instead of margins

Added by Roel Standaert about 2 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Target version:
Start date:
10/12/2022
Due date:
% Done:

0%

Estimated time:

Description

At the moment, when WBoxLayout is implemented using FlexLayoutImpl, any spacing is done using a margin.

This leads to an inconsistency between how flex layouts are rendered and how JavaScript layouts are rendered when the spacing is more than 2 times the contents margins.

I added an example to demonstrate what I'm talking about. It seems to me that gap (row-gap or column-gap) is really the appropriate property to set in order to make sure rendering is consistent.

I noticed this while working on issue #10967, and saw that the spacing variable was unused in the adjust function of FlexLayoutImpl.js.


Files

flexbox_spacing.cpp (2.03 KB) flexbox_spacing.cpp Roel Standaert, 10/12/2022 04:10 PM

No data to display

Also available in: Atom PDF