Project

General

Profile

Actions

Improvements #11001

closed

FlexLayoutImpl: consider using gap for spacing instead of margins

Added by Roel Standaert about 2 years ago. Updated 4 days ago.

Status:
Closed
Priority:
Normal
Target version:
Start date:
10/12/2022
Due date:
% Done:

100%

Estimated time:

Description

At the moment, when WBoxLayout is implemented using FlexLayoutImpl, any spacing is done using a margin.

This leads to an inconsistency between how flex layouts are rendered and how JavaScript layouts are rendered when the spacing is more than 2 times the contents margins.

I added an example to demonstrate what I'm talking about. It seems to me that gap (row-gap or column-gap) is really the appropriate property to set in order to make sure rendering is consistent.

I noticed this while working on issue #10967, and saw that the spacing variable was unused in the adjust function of FlexLayoutImpl.js.


Files

flexbox_spacing.cpp (2.03 KB) flexbox_spacing.cpp Roel Standaert, 10/12/2022 04:10 PM
Actions #1

Updated by Matthias Van Ceulebroeck 3 months ago

  • Assignee set to Romain Mardulyn
  • Target version changed from future to 4.11.2
Actions #2

Updated by Romain Mardulyn 3 months ago

  • Status changed from New to InProgress
Actions #3

Updated by Romain Mardulyn 3 months ago

  • Status changed from InProgress to Review
  • Assignee deleted (Romain Mardulyn)
Actions #4

Updated by Matthias Van Ceulebroeck 2 months ago

  • Assignee set to Matthias Van Ceulebroeck
Actions #5

Updated by Matthias Van Ceulebroeck 23 days ago

  • Status changed from Review to Implemented @Emweb
  • Assignee changed from Matthias Van Ceulebroeck to Romain Mardulyn
  • Target version changed from 4.11.2 to 4.11.1
  • % Done changed from 0 to 100
Actions #6

Updated by Matthias Van Ceulebroeck 18 days ago

  • Status changed from Implemented @Emweb to Implemented @Test
Actions #7

Updated by Matthias Van Ceulebroeck 4 days ago

  • Status changed from Implemented @Test to Closed
Actions

Also available in: Atom PDF