Actions
Improvements #11001
closedFlexLayoutImpl: consider using gap for spacing instead of margins
Start date:
10/12/2022
Due date:
% Done:
100%
Estimated time:
Description
At the moment, when WBoxLayout
is implemented using FlexLayoutImpl
, any spacing is done using a margin.
This leads to an inconsistency between how flex layouts are rendered and how JavaScript layouts are rendered when the spacing is more than 2 times the contents margins.
I added an example to demonstrate what I'm talking about. It seems to me that gap
(row-gap
or column-gap
) is really the appropriate property to set in order to make sure rendering is consistent.
I noticed this while working on issue #10967, and saw that the spacing
variable was unused in the adjust
function of FlexLayoutImpl.js
.
Files
Updated by Matthias Van Ceulebroeck 3 months ago
- Assignee set to Romain Mardulyn
- Target version changed from future to 4.11.2
Updated by Romain Mardulyn 3 months ago
- Status changed from InProgress to Review
- Assignee deleted (
Romain Mardulyn)
Updated by Matthias Van Ceulebroeck 2 months ago
- Assignee set to Matthias Van Ceulebroeck
Updated by Matthias Van Ceulebroeck 23 days ago
- Status changed from Review to Implemented @Emweb
- Assignee changed from Matthias Van Ceulebroeck to Romain Mardulyn
- Target version changed from 4.11.2 to 4.11.1
- % Done changed from 0 to 100
Updated by Matthias Van Ceulebroeck 18 days ago
- Status changed from Implemented @Emweb to Implemented @Test
Updated by Matthias Van Ceulebroeck 4 days ago
- Status changed from Implemented @Test to Closed
Actions