Project

General

Profile

Actions
Copy link

Bug #11009

closed
RS RM

StdGridLayoutImpl2.js: totalPreferredSize and totalMinSize are modified before declaration

Bug #11009: StdGridLayoutImpl2.js: totalPreferredSize and totalMinSize are modified before declaration

Added by Roel Standaert almost 4 years ago. Updated almost 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Romain Mardulyn
Target version:
4.11.1
Start date:
10/14/2022
Due date:
% Done:

100%

Estimated time:

Description

While working on issue #10967 I noticed that totalPreferredSize and totalMinSize were used before they were declared with var and given an initial value of 0.

I marked this with a FIXME comment "totalPreferredSize and totalMinSize are still undefined here?"

This likely indicates a bug. We should either look into it and fix it if we don't retire JS-based layouts altogether.

Related issues 1 (0 open — 1 closed)

Related to Improvements #10967: Add linting to Wt's JavaScript and address warnings coming from the linterClosedRoel Standaert09/22/2022

Actions

RS Updated by Roel Standaert almost 4 years ago Actions
Copy link
 #1

  • Related to Improvements #10967: Add linting to Wt's JavaScript and address warnings coming from the linter added

MV Updated by Matthias Van Ceulebroeck about 2 years ago Actions
Copy link
 #2

  • Assignee set to Romain Mardulyn
  • Target version changed from future to 4.11.2

RM Updated by Romain Mardulyn about 2 years ago Actions
Copy link
 #3

  • Status changed from New to InProgress

RM Updated by Romain Mardulyn about 2 years ago Actions
Copy link
 #4

  • Status changed from InProgress to Review

RM Updated by Romain Mardulyn about 2 years ago Actions
Copy link
 #5

  • Assignee deleted (Romain Mardulyn)

MV Updated by Matthias Van Ceulebroeck about 2 years ago Actions
Copy link
 #6

  • Assignee set to Matthias Van Ceulebroeck

MV Updated by Matthias Van Ceulebroeck almost 2 years ago Actions
Copy link
 #7

  • Status changed from Review to Implemented @Emweb
  • Assignee changed from Matthias Van Ceulebroeck to Romain Mardulyn
  • Target version changed from 4.11.2 to 4.11.1
  • % Done changed from 0 to 100

MV Updated by Matthias Van Ceulebroeck almost 2 years ago Actions
Copy link
 #8

  • Status changed from Implemented @Emweb to Implemented @Test

MV Updated by Matthias Van Ceulebroeck almost 2 years ago Actions
Copy link
 #9

  • Status changed from Implemented @Test to Closed
Actions
Copy link

Also available in: PDF Atom