Project

General

Profile

Actions

Bug #11009

closed

StdGridLayoutImpl2.js: totalPreferredSize and totalMinSize are modified before declaration

Added by Roel Standaert about 2 years ago. Updated 18 days ago.

Status:
Closed
Priority:
Normal
Target version:
Start date:
10/14/2022
Due date:
% Done:

100%

Estimated time:

Description

While working on issue #10967 I noticed that totalPreferredSize and totalMinSize were used before they were declared with var and given an initial value of 0.

I marked this with a FIXME comment "totalPreferredSize and totalMinSize are still undefined here?"

This likely indicates a bug. We should either look into it and fix it if we don't retire JS-based layouts altogether.


Related issues 1 (0 open1 closed)

Related to Improvements #10967: Add linting to Wt's JavaScript and address warnings coming from the linterClosedRoel Standaert09/22/2022

Actions
Actions #1

Updated by Roel Standaert about 2 years ago

  • Related to Improvements #10967: Add linting to Wt's JavaScript and address warnings coming from the linter added
Actions #2

Updated by Matthias Van Ceulebroeck 3 months ago

  • Assignee set to Romain Mardulyn
  • Target version changed from future to 4.11.2
Actions #3

Updated by Romain Mardulyn 3 months ago

  • Status changed from New to InProgress
Actions #4

Updated by Romain Mardulyn 3 months ago

  • Status changed from InProgress to Review
Actions #5

Updated by Romain Mardulyn 3 months ago

  • Assignee deleted (Romain Mardulyn)
Actions #6

Updated by Matthias Van Ceulebroeck 2 months ago

  • Assignee set to Matthias Van Ceulebroeck
Actions #7

Updated by Matthias Van Ceulebroeck about 1 month ago

  • Status changed from Review to Implemented @Emweb
  • Assignee changed from Matthias Van Ceulebroeck to Romain Mardulyn
  • Target version changed from 4.11.2 to 4.11.1
  • % Done changed from 0 to 100
Actions #8

Updated by Matthias Van Ceulebroeck about 1 month ago

  • Status changed from Implemented @Emweb to Implemented @Test
Actions #9

Updated by Matthias Van Ceulebroeck 18 days ago

  • Status changed from Implemented @Test to Closed
Actions

Also available in: Atom PDF