Project

General

Profile

Actions
Copy link

Improvements #13052

closed
MV RM

Do not generate an internal path for menu items if not enabled

Improvements #13052: Do not generate an internal path for menu items if not enabled

Added by Matthias Van Ceulebroeck almost 2 years ago. Updated 6 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Romain Mardulyn
Target version:
4.12.2
Start date:
09/17/2024
Due date:
% Done:

100%

Estimated time:

Description

When constructing a WMenuItem, this calls setText(). In case that there isn't a custom path component (which is always the case during construction), the internal path component is automatically generated from the text content.
This always does a narrow() call, to ensure that the component is URL-safe. While not necessarily a bad approach, this will produce a warning log in case character are not supported.

The generation of the path component ought to be delayed until it is enabled.

RM Updated by Romain Mardulyn over 1 year ago Actions
Copy link
 #1

  • Status changed from New to InProgress
  • Assignee set to Romain Mardulyn

RM Updated by Romain Mardulyn over 1 year ago Actions
Copy link
 #2

  • Status changed from InProgress to Review
  • Assignee deleted (Romain Mardulyn)

MV Updated by Matthias Van Ceulebroeck about 1 year ago Actions
Copy link
 #3

  • Target version changed from 4.12.0 to 4.12.2

MV Updated by Matthias Van Ceulebroeck 10 months ago Actions
Copy link
 #4

  • Assignee set to Matthias Van Ceulebroeck

MV Updated by Matthias Van Ceulebroeck 10 months ago Actions
Copy link
 #5

  • Status changed from Review to Implemented @Emweb
  • Assignee changed from Matthias Van Ceulebroeck to Romain Mardulyn
  • % Done changed from 0 to 100

RM Updated by Romain Mardulyn 6 months ago Actions
Copy link
 #6

  • Status changed from Implemented @Emweb to Closed
Actions
Copy link

Also available in: PDF Atom