Bug #1317
closedFix jQuery detection in WebRenderer
0%
Description
Allow jQuery detection to function properly, and remove the dash so that CDNs like Google, which do not include a dash in the filename, will be detected.
Files
Updated by Koen Deforche over 12 years ago
- Status changed from New to InProgress
- Assignee set to Pieter Libin
- Target version set to 3.2.2
Patch looks okay, can you apply ?
Updated by Jake Petroules over 12 years ago
I'm a bit concerned that I had to remove - app->scriptLibrariesAdded_ for this code to even have an effect at all, because I don't know why it was there in the first place.
I looked through everywhere it was referenced and from what I understand, the original code would effectively cause the array to never be iterated in any situation. So this seemed like a perfectly reasonable fix. Do any of you have anything to say on this? I just want to be sure I don't introduce a bug by fixing another. :)
Updated by Pieter Libin over 12 years ago
Hey Jake,
your change on the for loop is correct, and indeed fixes a bug.
Kind regards,
Pieter
Updated by Pieter Libin over 12 years ago
- Status changed from InProgress to Resolved
Updated by Koen Deforche over 12 years ago
- Status changed from Resolved to Closed
Released in Wt 3.2.2