Project

General

Profile

Actions

Bug #13300

open

Correct windows state management

Added by Matthias Van Ceulebroeck 16 days ago. Updated 3 days ago.

Status:
Implemented @Emweb
Priority:
Normal
Target version:
Start date:
12/06/2024
Due date:
% Done:

0%

Estimated time:

Description

When Wt added linting (#10967) to ensure that JS code is formatted and consistent, a very subtly difference was introduced to the behavior that manages window state.
When pressing browser back and forward buttons, Wt will retrieve the correct internal path that displayed the page. This ensures that pages are loaded once, and that Wt can serve as a single-page application.

When linting was introduced, this enforces stronger typing (e.g. using === over ==). Previously a check like variable == null would succeed if the variable is either null OR undefined. However, with the introduction of === this is no longer the case because null === undefined is not true.

This means that Wt's last resort retrieval of the previous internal path was no longer functioning. In a case where a page is initially loaded, and we navigate to a page which internal path is rewritten (to e.g. obscure sensitive data), no correct fallback would be found.

Actions #1

Updated by Matthias Van Ceulebroeck 16 days ago

  • Status changed from InProgress to Review
  • Assignee deleted (Matthias Van Ceulebroeck)
Actions #2

Updated by Romain Mardulyn 16 days ago

  • Assignee set to Romain Mardulyn
Actions #3

Updated by Romain Mardulyn 3 days ago

  • Status changed from Review to Implemented @Emweb
  • Assignee changed from Romain Mardulyn to Matthias Van Ceulebroeck
Actions

Also available in: Atom PDF