Bug #13408: WSortFilterProxyModel sends wrong information about inserted rows - Wt - Redmine

Actions

Copy link

Bug #13408

open

WSortFilterProxyModel sends wrong information about inserted rows

Added by Stephan Ehlers 11 months ago. Updated about 1 month ago.

Status:

Implemented @Test

Priority:

Normal

Assignee:

Stephan Ehlers

Target version:

4.12.2

Start date:

01/10/2025

Due date:

% Done:

Estimated time:

Description

If rows to a model are inserted via a WSortFilterProxyModel (i.e. a call to WSortFilterProxyModel::insertRows()), while the current implementation asks the underlying model to insert the correct number of rows, it then proceeds to assume that only exactly one row has been added in all cases.

I created a PR on github (https://github.com/emweb/wt/pull/224) to fix this; it is based on Wt 4.11.1 and applies without issues to 4.10.4 as well.

Related issues 1 (1 open — 0 closed)

Actions

Copy link

Updated by Matthias Van Ceulebroeck about 1 month ago

Status changed from New to InProgress
Assignee changed from Stephan Ehlers to Matthias Van Ceulebroeck
Target version set to 4.12.2
% Done changed from 80 to 0

Actions

Copy link

Updated by Matthias Van Ceulebroeck about 1 month ago

Status changed from InProgress to Review

The PR will be merged as-is, and an additional ticket will be made to go farther in fixing the models.
There seem to be a variety of small use-cases not covered, or behaving slightly different than expected.

These will be fixed in the other ticket, and tests will be added for it.

Actions

Copy link