Actions
Bug #13417
closed
MV
RM
Verify heap-buffer-overflow in createSalt
Bug #13417:
Verify heap-buffer-overflow in createSalt
Start date:
01/15/2025
Due date:
% Done:
0%
Estimated time:
Description
Due to how this function is implemented, always copying three bytes, a heap-buffer-overflow has been introduced here.
Wt ought to be more defensive here. There are three choices:
-
do not allow non-three divisible input. Simply throw an exception here. This seems excessive.
-
correct the requested length to be valid. Again, this is tampering with what Wt shouldn't tamper with.
-
correct the
saltBufvariable, to contain two bytes more, ensuring any input always fits.
Only the last option seems to be a valid approach.
Of course, we should implement some tests (on length) to ensure its output is valid.
RM Updated by Romain Mardulyn over 1 year ago
- Status changed from New to InProgress
- Assignee set to Romain Mardulyn
RM Updated by Romain Mardulyn over 1 year ago
- Status changed from InProgress to Review
- Assignee deleted (
Romain Mardulyn)
MV Updated by Matthias Van Ceulebroeck about 1 year ago
- Target version changed from 4.12.0 to 4.12.3
MV Updated by Matthias Van Ceulebroeck 8 months ago
- Assignee set to Matthias Van Ceulebroeck
RM Updated by Romain Mardulyn 8 months ago
- Target version changed from 4.12.3 to 4.12.4
RM Updated by Romain Mardulyn 8 months ago
- Status changed from Review to Implemented @Emweb
- Assignee changed from Matthias Van Ceulebroeck to Romain Mardulyn
RM Updated by Romain Mardulyn 7 months ago
- Status changed from Implemented @Emweb to Closed
Actions