Project

General

Profile

Actions
Copy link

Bug #14054

closed

WItemDelegate does not safely use (set)editState

Added by Stephan Ehlers 7 months ago. Updated 28 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Romain Mardulyn
Target version:
4.13.0
Start date:
10/16/2025
Due date:
% Done:

100%

Estimated time:

Description

WItemDelegate does not check whether dynamic casts were successful in editState and setEditState, even though the editor could have been replaced by somebody overriding createEditor.

As with updateModelIndex, these two methods should do nothing in case a user forgot to implement them - instead of crashing the software.

I created a PR on github (https://github.com/emweb/wt/pull/234) to modify this behavior.

Actions
Copy link
 #1

Updated by Romain Mardulyn about 2 months ago

  • Status changed from New to InProgress
  • Assignee set to Romain Mardulyn
  • Target version set to 4.13.0
Actions
Copy link
 #2

Updated by Romain Mardulyn about 1 month ago

  • Status changed from InProgress to Review
  • Assignee deleted (Romain Mardulyn)
Actions
Copy link
 #3

Updated by Matthias Van Ceulebroeck about 1 month ago

  • Assignee set to Matthias Van Ceulebroeck
Actions
Copy link
 #4

Updated by Romain Mardulyn about 1 month ago

  • Status changed from Review to Implemented @Emweb
  • Assignee changed from Matthias Van Ceulebroeck to Romain Mardulyn
Actions
Copy link
 #5

Updated by Romain Mardulyn 28 days ago

  • Status changed from Implemented @Emweb to Closed
Actions
Copy link

Also available in: Atom PDF