Bug #1687: load external images through redirect in HTML version (patch attached) - Wt - Redmine

Actions

Copy link

Bug #1687

closed

load external images through redirect in HTML version (patch attached)

Added by Boris Nagaev almost 12 years ago. Updated almost 12 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Koen Deforche

Target version:

3.3.0

Start date:

02/11/2013

Due date:

% Done:

Estimated time:

Files

escape-src-and-style.diff (2.74 KB) escape-src-and-style.diff

Boris Nagaev, 02/11/2013 03:26 PM

Actions

Copy link

Updated by Koen Deforche almost 12 years ago

Status changed from New to InProgress
Assignee set to Koen Deforche

Hey Starius,

Nice ! I might start to make a habit of leaving TODO trails in the code :-)

I do think that the regular expression needs some more tweaking to handle uri scheme relative urls.

http://stackoverflow.com/questions/3583103/network-path-reference-uri-scheme-relative-urls

Koen

Actions

Copy link

Updated by Boris Nagaev almost 12 years ago

Hello!

I did not know about relative uri schemes. Thank you!

BTW "://" is used several times in Wt (not only in proposed patch) to detect external images.

Files:

Wt/Http/Client.C

Wt/WApplication.C (in function encodeUntrustedUrl, which is called from RefEncoder)

web/WebSession.C

web/skeleton/Wt.js (var crossDomain = url.indexOf("://") != --1 and other, seems to be a bug!)

web/RefEncoder.C

web/WebRenderer.C

Actions

Copy link