Project

General

Profile

Actions
Copy link

Bug #2533

closed

Wt::Dbo::Session::tableCreationSql() omits statement terminating semicolons

Added by Bruce Toll almost 11 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Low
Assignee:
-
Target version:
3.3.2
Start date:
01/02/2014
Due date:
% Done:

0%

Estimated time:

Description

The output of tableCreationSql() does not include terminating semicolons. Tested with Wt::Dbo::backend::Postgres and github version (3.3.1-22-g11485bb).

Note: The output of tableCreationSql does not appear to be used directly by Wt, aside from test/dbo/DboTest.C.

Attached patch trims whitespace and adds semicolon. It's only had minimal testing and might break code depending on existing behavior.

Files

tableCreationSql_semicolon_20140102a.diff (650 Bytes) tableCreationSql_semicolon_20140102a.diff Bruce Toll, 01/03/2014 12:32 AM
Actions
Copy link
 #1

Updated by Koen Deforche almost 11 years ago

  • Status changed from New to Resolved
  • Target version set to 3.3.2

Hey,

Thanks. A fix is on the way (we'll simply generate the SQL correctly rather than fixing it later).

Regards,

koen

Actions
Copy link
 #2

Updated by Bruce Toll almost 11 years ago

Hey Koen,

Thanks. That makes a lot of sense. BTW, the 3D charts are really impressive.

Regards,

Bruce

Actions
Copy link
 #3

Updated by Koen Deforche almost 11 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF