Project

General

Profile

Actions
Copy link

Feature #2576

closed

Dbo: Consider including a Dbo test case with LEFT JOIN query

Added by Bruce Toll almost 11 years ago. Updated almost 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Koen Deforche
Target version:
3.3.2
Start date:
01/19/2014
Due date:
% Done:

0%

Estimated time:

Description

The attached patch adds a test case with a LEFT JOIN query to DboTest.C.

The patch also includes a fix for an unitialized variable that gets driven by the LEFT JOIN example.

Patch is formatted with "git format-patch" against github master 3.3.1-22-g11485bb. It has only been lightly tested.

Files

0001-Dbo-test-for-left-join-uninitialized-value-fix.patch (4.76 KB) 0001-Dbo-test-for-left-join-uninitialized-value-fix.patch Bruce Toll, 01/19/2014 01:54 AM
Actions
Copy link
 #1

Updated by Koen Deforche almost 11 years ago

  • Status changed from New to Resolved
  • Assignee set to Koen Deforche
  • Target version set to 3.3.2

Hey,

Thanks for this. I took your patch as a basis, but return really null (default constructed) ptr's instead of allocating objects with an invalid ID, and also implemented this for natural ID's.

Regards,

koen

Actions
Copy link
 #2

Updated by Bruce Toll almost 11 years ago

Hey Koen,

Thanks for the explanation. Your modification makes a lot more sense.

The Dbo design is very elegant.

Regards,

Bruce

Actions
Copy link
 #3

Updated by Koen Deforche almost 11 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF