Feature #3317: Chart::WAxis add autoDateFormat() virtual function - Wt - Redmine

Actions

Copy link

Feature #3317

closed

Chart::WAxis add autoDateFormat() virtual function

Added by Stefan Ruppert over 10 years ago. Updated over 9 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Benoit Daccache

Target version:

3.3.5

Start date:

06/12/2014

Due date:

% Done:

Estimated time:

Description

Hi,

currently automatic DateTimeScale uses hard-coded date/time formats within WAxis::getLabelTicks() function. Add a protected

protected:
    virtual Wt::WString autoDataFormat(const WDateTime& dt, DateTimeUnit unit, bool atTick);

and use the current hard-coded formats as a default implementation.

See the attached patches. Note I just wrote down the changes but did not compiled or tested it.

Files

Download all files

WAxis.C.patch (3.33 KB) WAxis.C.patch	WAxis.C patch	Stefan Ruppert, 06/12/2014 05:27 PM
WAxis.patch (735 Bytes) WAxis.patch	WAxis patch	Stefan Ruppert, 06/12/2014 05:27 PM
WAxis.patch (1.37 KB) WAxis.patch	A new patch using a boost::function delegate	Stefan Ruppert, 07/17/2014 01:02 PM
WAxis.C.patch (1.24 KB) WAxis.C.patch	A new patch using a boost::function delegate	Stefan Ruppert, 07/17/2014 01:02 PM

Actions

Copy link Download all files

Updated by Stefan Ruppert over 10 years ago

File WAxis.patch WAxis.patch added
File WAxis.C.patch WAxis.C.patch added

Hi,

today I have changed WAxis to be able to call a user-defined autoDateFormat() function. I realized that a protected function does not work, since the WAxis instances are members of the chart. Therefore a introduced a setAutoDateFormat(boost::function fn) method which can be used to set a delegate method.

I would really like to see this feature included into Wt!

Regards,

Stefan

Actions

Copy link

Updated by Koen Deforche over 10 years ago

Status changed from New to Feedback

Hey,

Perhaps the virtual function is better; but then we simply need to change how we store WAxis in WCartesianChart (i.e. with pointer) and provide setAxis() functions?

In that way, the same functionality can be made available in Java as well (which doesn't have function objects).

Regards,

koen

Actions

Copy link

Updated by Stefan Ruppert over 10 years ago

Hi Keon,

currently we use the provided patch to add this functionality to wt-3.3.2 which we currently use for production. I have no problem to change it to a virtual function when upgrading to wt-3.3.4.

Regards,

Stefan

Actions

Copy link