Project

General

Profile

Actions
Copy link

Bug #3514

closed
JL RS

Wt 3.3.3 WBatchEditProxyModel::flags() breaks model Indexes

Bug #3514: Wt 3.3.3 WBatchEditProxyModel::flags() breaks model Indexes

Added by Jan Lindemann about 12 years ago. Updated almost 12 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Roel Standaert
Target version:
3.3.4
Start date:
08/04/2014
Due date:
% Done:

0%

Estimated time:

Description

Dear Devs,

WBatchEditProxyModel's flags() method in Wt 3.3.3 passes inconsistent indexes
to the proxied model.

The attached patch fixes that and works for me. It also patches the unit test,
I haven't actually verified that part, though.

Best regards,

Jan

Files

w-batch-edit-proxy-model-fix-broken-indexes.patch (1.32 KB) w-batch-edit-proxy-model-fix-broken-indexes.patch Jan Lindemann, 08/04/2014 02:15 PM

KD Updated by Koen Deforche about 12 years ago Actions
Copy link
 #1

  • Status changed from New to InProgress
  • Assignee set to Roel Standaert
  • Target version set to 3.3.4

RS Updated by Roel Standaert about 12 years ago Actions
Copy link
 #2

  • Status changed from InProgress to Resolved
return sourceModel()->flags(index);

indeed needs to be

return sourceModel()->flags(sourceIndex);

. The

return WAbstractProxyModel::flags(index);

line is correct, though. I've fixed it and implemented a working test.

JL Updated by Jan Lindemann about 12 years ago Actions
Copy link
 #3

Ah, I see. Thank you!

KD Updated by Koen Deforche almost 12 years ago Actions
Copy link
 #4

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: PDF Atom