Project

General

Profile

Actions
Copy link

Bug #3514

closed

Wt 3.3.3 WBatchEditProxyModel::flags() breaks model Indexes

Added by Jan Lindemann over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Roel Standaert
Target version:
3.3.4
Start date:
08/04/2014
Due date:
% Done:

0%

Estimated time:

Description

Dear Devs,

WBatchEditProxyModel's flags() method in Wt 3.3.3 passes inconsistent indexes

to the proxied model.

The attached patch fixes that and works for me. It also patches the unit test,

I haven't actually verified that part, though.

Best regards,

Jan

Files

w-batch-edit-proxy-model-fix-broken-indexes.patch (1.32 KB) w-batch-edit-proxy-model-fix-broken-indexes.patch Jan Lindemann, 08/04/2014 02:15 PM
Actions
Copy link
 #1

Updated by Koen Deforche over 9 years ago

  • Status changed from New to InProgress
  • Assignee set to Roel Standaert
  • Target version set to 3.3.4
Actions
Copy link
 #2

Updated by Roel Standaert over 9 years ago

  • Status changed from InProgress to Resolved
return sourceModel()->flags(index);

indeed needs to be

return sourceModel()->flags(sourceIndex);

. The

return WAbstractProxyModel::flags(index);

line is correct, though. I've fixed it and implemented a working test.

Actions
Copy link
 #3

Updated by Jan Lindemann over 9 years ago

Ah, I see. Thank you!

Actions
Copy link
 #4

Updated by Koen Deforche over 9 years ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF