Project

General

Profile

Actions

Feature #3974

closed

[PATCH] WLink and WItemDelegate to support TargetNewWindow

Added by Stefan Ruppert over 9 years ago. Updated over 9 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Benoit Daccache
Target version:
Start date:
04/10/2015
Due date:
% Done:

0%

Estimated time:

Description

Hi,

within some of my table views I want to present a link with target type TargetNewWindow. Currently this does not work since setTarget() is only available within WAnchor class. Within a model within the LinkRole only a WLink instance can be returned! Therefore I added two methods WLink::target() and WLink::setTarget() and changed the WItemDelegate to use WLink::target() instead of checking the WLink::type()...

Attached is the appropriate patch.

Regards,

Stefan


Files

WLinkTarget.patch (2.15 KB) WLinkTarget.patch patching WLink and WItemDelegate classes Stefan Ruppert, 04/10/2015 08:34 AM
Actions #1

Updated by Koen Deforche over 9 years ago

  • Status changed from New to InProgress
  • Assignee set to Michael Vilsker

There are probably other places where we should use the target stored in WLink (WAnchor.LinkState)

Actions #2

Updated by Koen Deforche over 9 years ago

  • Status changed from InProgress to Resolved
Actions #3

Updated by Koen Deforche over 9 years ago

  • Status changed from Resolved to InProgress
  • Assignee changed from Michael Vilsker to Benoit Daccache
  • Target version set to 3.3.5

Benoit can you check that we also included the WItemDelegate part?

Actions #4

Updated by Benoit Daccache over 9 years ago

  • Status changed from InProgress to Resolved

changed the WItemDelegate to use WLink::target() instead of checking the WLink::type()

Actions #5

Updated by Koen Deforche over 9 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF