Project

General

Profile

Actions

Bug #4906

closed
KD RS

Case insensitive identity comparison in Wt::Auth

Bug #4906: Case insensitive identity comparison in Wt::Auth

Added by Koen Deforche over 10 years ago. Updated over 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Roel Standaert
Target version:
Start date:
05/10/2016
Due date:
% Done:

0%

Estimated time:

Description

Comparison of identities (e.g. user name, email address, ...) should be case insensitive.

RS Updated by Roel Standaert over 10 years ago Actions #1

  • Status changed from New to Implemented @Emweb

It's case insensitive now for e-mail addresses (in the Wt::Dbo implementation of the user database), if the AuthService is passed to the UserDatabase.

KD Updated by Koen Deforche over 10 years ago Actions #2

  • Status changed from Implemented @Emweb to Resolved

KD Updated by Koen Deforche about 10 years ago Actions #3

  • Status changed from Resolved to Closed

SH Updated by Stefan Hendrickx over 6 years ago Actions #4

This issue appears to be resolved for email addresses, but not for username?

RS Updated by Roel Standaert over 6 years ago Actions #5

Commit 0a57164a976214e0479eac520080017150323ddb indeed makes it case insensitive for email addresses only, so it's been like that since Wt 3.3.6. This is because email addresses are generally case insensitive (even though technically only the hostname part is defined as being case insensitive).

Making the identity case insensitive in general would be a significant behavioral change. I think we'd have to make it optional.

RS Updated by Roel Standaert over 6 years ago Actions #6

It's probably best that you override UserDatabase::findWithIdentity for this purpose, since we can't do it in general.

Actions

Also available in: PDF Atom