Project

General

Profile

Actions

Bug #6576

closed

Wt 3.3.11 Javascript WTimer issue

Added by Mark O'Donovan almost 6 years ago. Updated over 5 years ago.

Status:
Closed
Priority:
Normal
Assignee:
-
Target version:
Start date:
08/29/2018
Due date:
% Done:

0%

Estimated time:

Description

Hi,

I'm experiencing an issue after upgrading to 3.3.11.

After the application loads it sometimes locks up.

I can refresh the page and try again.

If it doesn't lock up immediately I click through to show a tableview where it will definitely lock up.

Basically it becomes unresponsive and shows the "Loading..." message in the top right corner.

The wt process will also have high CPU usage.

Affected browsers also have very high CPU usage.

I have a browser running on the same device as the server and it never seems to be affected whereas remote browsers seem to always be affected.

The issue was introduced in commit b5b098b80f724c86e69ed4de7a17b1068dfe225c

and disappears with the following patch

diff --git a/src/Wt/WTimerWidget.C b/src/Wt/WTimerWidget.C
index 6d9b68a..9eae456 100644
--- a/src/Wt/WTimerWidget.C
+++ b/src/Wt/WTimerWidget.C
@@ -34,7 +34,7 @@ std::string WTimerWidget::renderRemoveJs(bool recursive)
 void WTimerWidget::timerStart(bool jsRepeat)
 {
   timerStarted_ = true;
-  jsRepeat_ = jsRepeat;
+  jsRepeat_ = false;

   repaint();
 }

The application is quite large with around 35 timers.

Perhaps i'm using too many?

I've included my wt.log below (10.130.44.248 is running the wt server):

[2018-Aug-30 08:32:32.815185] 776 [/ ifNuxZr9F1vjBd7m] [warning] "WApplication: Deploy-path ends with '/', using /?_= for internal paths"
[2018-Aug-30 08:32:32.874607] 776 [/ ifNuxZr9F1vjBd7m] [error] "XSS: Error reading XHTML string: could not parse xhtml entity"
[2018-Aug-30 08:32:32.878352] 776 [/ ifNuxZr9F1vjBd7m] [error] "XSS: Error reading XHTML string: could not parse xhtml entity"
[2018-Aug-30 08:32:32.879879] 776 [/ ifNuxZr9F1vjBd7m] [error] "XSS: Error reading XHTML string: could not parse xhtml entity"
[2018-Aug-30 08:32:33.359131] 776 [/ ifNuxZr9F1vjBd7m] [error] "XSS: Error reading XHTML string: expected >"
[2018-Aug-30 08:32:36.349804] 776 [/ ifNuxZr9F1vjBd7m] [error] "XSS: Error reading XHTML string: invalid closing tag name"
[2018-Aug-30 08:33:01.968079] 776 [/ wLtGJnVzTXJAyMrV] [error] "Wt: WebSocket request refused: Origin 'http://10.130.44.248' not allowed (trusted origin is '://')"
[2018-Aug-30 08:33:02.018257] 776 [/ KGaeZEtIBanNn8L5] [warning] "WApplication: Deploy-path ends with '/', using /?_= for internal paths"
[2018-Aug-30 08:33:05.738810] 776 [/ 2FlbDf3Lq4vXnrH9] [notice] "User admin login"
[2018-Aug-30 08:33:05.780592] 776 [/ 2FlbDf3Lq4vXnrH9] [error] "XSS: Error reading XHTML string: could not parse xhtml entity"
[2018-Aug-30 08:33:05.784610] 776 [/ 2FlbDf3Lq4vXnrH9] [error] "XSS: Error reading XHTML string: could not parse xhtml entity"
[2018-Aug-30 08:33:05.786269] 776 [/ 2FlbDf3Lq4vXnrH9] [error] "XSS: Error reading XHTML string: could not parse xhtml entity"
[2018-Aug-30 08:33:06.248918] 776 [/ 2FlbDf3Lq4vXnrH9] [error] "XSS: Error reading XHTML string: expected >"
[2018-Aug-30 08:33:06.908729] 776 [/ 2FlbDf3Lq4vXnrH9] [error] "XSS: Error reading XHTML string: invalid closing tag name"

Let me know if you need more info.

Thanks,

Mark


Files

bug_6576.patch (1.59 KB) bug_6576.patch Roel Standaert, 08/29/2018 02:29 PM
Actions #1

Updated by Roel Standaert almost 6 years ago

Yeah, we've also just noticed this regression. I'm working to fix it. For now, you can revert to the old behavior with the attached patch.

Actions #2

Updated by Roel Standaert almost 6 years ago

  • Status changed from New to Resolved

I just pushed a fix.

Actions #3

Updated by Mark O'Donovan almost 6 years ago

Works for me, Thanks

Actions #4

Updated by Roel Standaert over 5 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF