Project

General

Profile

Actions
Copy link

Improvements #8629

closed

Change JavaScript minifier

Added by Roel Standaert almost 3 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Roel Standaert
Target version:
4.9.0
Start date:
06/03/2021
Due date:
% Done:

100%

Estimated time:

Description

We've been using the same old version of Google's Closure Compiler for minification. This is a hurdle for contributors. We should probably switch to some more recent minifier. Care should be taken to see that using a different minifier does not break anything.

The -DWT_DEBUG_JS define is also a bit obscure, and should probably be included into a proper CMake option?

Related issues 1 (0 open — 1 closed)

Related to Bug #11006: filetostring.cmake generates file literals that exceed the minimum maximum string literal lengthClosedRoel Standaert10/13/2022

Actions
Actions
Copy link
 #1

Updated by Roel Standaert over 1 year ago

  • Status changed from New to InProgress
  • Assignee set to Roel Standaert
  • Target version changed from future to 4.9.0
Actions
Copy link
 #2

Updated by Roel Standaert over 1 year ago

  • Status changed from InProgress to Review
  • Assignee deleted (Roel Standaert)
Actions
Copy link
 #3

Updated by Roel Standaert over 1 year ago

  • Assignee set to Korneel Dumon
Actions
Copy link
 #4

Updated by Roel Standaert over 1 year ago

  • Status changed from Review to Implemented @Emweb
  • Assignee changed from Korneel Dumon to Roel Standaert
  • % Done changed from 0 to 100
Actions
Copy link
 #5

Updated by Roel Standaert over 1 year ago

  • Status changed from Implemented @Emweb to Resolved
Actions
Copy link
 #6

Updated by Roel Standaert over 1 year ago

  • Related to Bug #11006: filetostring.cmake generates file literals that exceed the minimum maximum string literal length added
Actions
Copy link
 #7

Updated by Roel Standaert over 1 year ago

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: Atom PDF