Actions
Bug #11006
closed
RS
RS
filetostring.cmake generates file literals that exceed the minimum maximum string literal length
Bug #11006:
filetostring.cmake generates file literals that exceed the minimum maximum string literal length
Start date:
10/13/2022
Due date:
% Done:
100%
Estimated time:
Description
The C++ standard sets the minimum maximum string literal length to 65536 characters: https://timsong-cpp.github.io/cppwp/n4140/implimits#2.15
Some compilers actually have this maximum, like the VS2017 compiler. Other compilers, like clang, will produce a -Woverlength-strings warning.
In order to comply with the standard, we could change our filetostring code to e.g. output an array of hex characters instead of using a string literal.
RS Updated by Roel Standaert almost 4 years ago
- Related to Improvements #8629: Change JavaScript minifier added
RS Updated by Roel Standaert almost 4 years ago
- Related to Bug #10941: [MSVC] Wt failed to build with error C2026 on MSVC added
RS Updated by Roel Standaert almost 4 years ago
- Status changed from New to InProgress
RS Updated by Roel Standaert almost 4 years ago
- Status changed from InProgress to Review
- Assignee changed from Roel Standaert to Korneel Dumon
RS Updated by Roel Standaert almost 4 years ago
- Priority changed from Normal to High
This issue is blocking the 4.9.0 release and must be resolved for release, hence bumping priority up to high.
KD Updated by Korneel Dumon almost 4 years ago
- Assignee changed from Korneel Dumon to Roel Standaert
RS Updated by Roel Standaert almost 4 years ago
- Status changed from Review to Implemented @Emweb
- % Done changed from 0 to 100
RS Updated by Roel Standaert almost 4 years ago
- Status changed from Implemented @Emweb to Resolved
RS Updated by Roel Standaert over 3 years ago
- Status changed from Resolved to Closed
Actions