Project

General

Profile

Actions

Bug #11006

closed
RS RS

filetostring.cmake generates file literals that exceed the minimum maximum string literal length

Bug #11006: filetostring.cmake generates file literals that exceed the minimum maximum string literal length

Added by Roel Standaert almost 4 years ago. Updated over 3 years ago.

Status:
Closed
Priority:
High
Assignee:
Roel Standaert
Target version:
Start date:
10/13/2022
Due date:
% Done:

100%

Estimated time:

Description

The C++ standard sets the minimum maximum string literal length to 65536 characters: https://timsong-cpp.github.io/cppwp/n4140/implimits#2.15

Some compilers actually have this maximum, like the VS2017 compiler. Other compilers, like clang, will produce a -Woverlength-strings warning.

In order to comply with the standard, we could change our filetostring code to e.g. output an array of hex characters instead of using a string literal.


Related issues 2 (0 open2 closed)

Related to Improvements #8629: Change JavaScript minifierClosedRoel Standaert06/03/2021

Actions
Related to Bug #10941: [MSVC] Wt failed to build with error C2026 on MSVCClosedRoel Standaert09/14/2022

Actions

RS Updated by Roel Standaert almost 4 years ago Actions #1

RS Updated by Roel Standaert almost 4 years ago Actions #2

  • Related to Bug #10941: [MSVC] Wt failed to build with error C2026 on MSVC added

RS Updated by Roel Standaert almost 4 years ago Actions #3

  • Status changed from New to InProgress

RS Updated by Roel Standaert almost 4 years ago Actions #4

  • Status changed from InProgress to Review
  • Assignee changed from Roel Standaert to Korneel Dumon

RS Updated by Roel Standaert almost 4 years ago Actions #5

  • Priority changed from Normal to High

This issue is blocking the 4.9.0 release and must be resolved for release, hence bumping priority up to high.

KD Updated by Korneel Dumon almost 4 years ago Actions #6

  • Assignee changed from Korneel Dumon to Roel Standaert

RS Updated by Roel Standaert almost 4 years ago Actions #7

  • Status changed from Review to Implemented @Emweb
  • % Done changed from 0 to 100

RS Updated by Roel Standaert almost 4 years ago Actions #8

  • Status changed from Implemented @Emweb to Resolved

RS Updated by Roel Standaert over 3 years ago Actions #9

  • Status changed from Resolved to Closed
Actions

Also available in: PDF Atom