Project

General

Profile

Actions

Improvements #11772

closed

Eleminate some warnings when compiling Wt with Clang

Added by Stefan Bn over 1 year ago. Updated about 2 months ago.

Status:
Closed
Priority:
Normal
Target version:
Start date:
06/24/2023
Due date:
% Done:

100%

Estimated time:

Description

When compiling Wt with Clang several warnings are created. The dev team might not be aware of this, if they do not compile using Clang.

However it would be nice to have a completely 'clean' Wt compile process. So please consider fixing these warnings:

[112/417] Building CXX object src/CMakeFiles/wt.dir/Wt/WIdentityProxyModel.C.obj
In file included from D:/Dev/BuildLibs/wt/wt-4.10.0/src/Wt/WIdentityProxyModel.C:7:
D:/Dev/BuildLibs/wt/wt-4.10.0/src/Wt/WIdentityProxyModel.h:130:8: warning: 'setHeaderData' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
  bool setHeaderData(int section, Orientation orientation,
       ^
D:/Dev/BuildLibs/wt/wt-4.10.0/src/Wt/WAbstractItemModel.h:456:16: note: overridden virtual function is here
  virtual bool setHeaderData(int section, Orientation orientation,
               ^
1 warning generated.
[300/417] Building CXX object src/CMakeFiles/wt.dir/Wt/Chart/WCartesianChart.C.obj
D:/Dev/BuildLibs/wt/wt-4.10.0/src/Wt/Chart/WCartesianChart.C:4516:15: warning: enumeration values 'CenterX' and 'CenterY' not handled in switch [-Wswitch]
      switch (legendSide()) {
              ^~~~~~~~~~~~
D:/Dev/BuildLibs/wt/wt-4.10.0/src/Wt/Chart/WCartesianChart.C:4619:15: warning: enumeration values 'CenterX' and 'CenterY' not handled in switch [-Wswitch]
      switch (legendSide()) {
              ^~~~~~~~~~~~
2 warnings generated.
[381/417] Building CXX object src/CMakeFiles/wt.dir/Wt/Date/src/tz.cpp.obj
D:/Dev/BuildLibs/wt/wt-4.10.0/src/Wt/Date/src/tz.cpp:66:15: warning: '_WIN32_WINNT' macro redefined [-Wmacro-redefined]
#define _WIN32_WINNT _WIN32_WINNT_VISTA
              ^
<command line>:14:9: note: previous definition is here
#define _WIN32_WINNT 0x0600
        ^
1 warning generated.
[387/417] Building CXX object src/http/CMakeFiles/wthttp.dir/Request.C.obj
D:/Dev/BuildLibs/wt/wt-4.10.0/src/http/Request.C:26:9: warning: 'HAVE_STRCASECMP' macro redefined [-Wmacro-redefined]
#define HAVE_STRCASECMP
        ^
<command line>:9:9: note: previous definition is here
#define HAVE_STRCASECMP 1
        ^
D:/Dev/BuildLibs/wt/wt-4.10.0/src/http/Request.C:27:9: warning: 'HAVE_STRNCASECMP' macro redefined [-Wmacro-redefined]
#define HAVE_STRNCASECMP
        ^
<command line>:10:9: note: previous definition is here
#define HAVE_STRNCASECMP 1
        ^

Thanks!
Stefan

Actions #1

Updated by Matthias Van Ceulebroeck about 1 year ago

  • Target version set to 4.10.2
Actions #2

Updated by Matthias Van Ceulebroeck about 1 year ago

  • Status changed from New to InProgress
  • Assignee set to Matthias Van Ceulebroeck
Actions #3

Updated by Matthias Van Ceulebroeck about 1 year ago

  • Target version changed from 4.10.2 to 4.10.3
Actions #4

Updated by Matthias Van Ceulebroeck 12 months ago

  • Status changed from InProgress to Review
  • Assignee changed from Matthias Van Ceulebroeck to Yoika Ghysens
Actions #5

Updated by Matthias Van Ceulebroeck 4 months ago

  • Status changed from Review to Implemented @Emweb
  • Assignee changed from Yoika Ghysens to Matthias Van Ceulebroeck
  • Target version changed from 4.10.3 to 4.11.0
  • % Done changed from 0 to 100
Actions #6

Updated by Matthias Van Ceulebroeck about 2 months ago

  • Status changed from Implemented @Emweb to Closed
Actions

Also available in: Atom PDF