Project

General

Profile

Actions
Copy link

Bug #12145

closed

WVBoxLayout: vertical placement is ignored in 4.10.2

Added by S ET about 1 year ago. Updated 4 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Matthias Van Ceulebroeck
Target version:
4.10.4
Start date:
11/11/2023
Due date:
% Done:

100%

Estimated time:

Description

Hi,

Since 4.10.2, widgets are not placed vertically in a WVBoxLayout, but horizontally instead. Same in c1abebc. It's OK in 4.10.0 and 4.10.1.

Thanks for considering.

Regards.

Files

wt-vbox.zip (2.29 KB) wt-vbox.zip S ET, 11/14/2023 10:07 PM
Actions
Copy link
 #1

Updated by Matthias Van Ceulebroeck about 1 year ago

  • Status changed from New to Feedback
  • Assignee set to S ET

Hello,

if I look at /layout/layout-managers of the widget gallery (locally, since the one publicly hosted at https://www.webtoolkit.eu/ is lagging behind a version currently) I do not see this behavior. The text there is still positioned as expected, namely vertically stacked.
Perhaps there is another layout manager that doesn't play nice? Could you provide a minimal example that exhibits the wrong visual layout?

Actions
Copy link
 #2

Updated by S ET about 1 year ago

Perhaps there is another layout manager that doesn't play nice? Could you provide a minimal example that exhibits the wrong visual layout?

Hi,

The attached file below contains sample project files demonstrating the issue.

It happens in a WPopupWidget, having a WVBoxLayout containing a WSelectionBox, a WCheckBox and 4 WPushButton widgets in a WGridLayout. When the popup is shown, the widget layout is bad in 4.10.2.

If the same widget disposition is applied in root(), the layout is good.

Thank you for considering.

Actions
Copy link
 #3

Updated by Matthias Van Ceulebroeck 12 months ago

  • Status changed from Feedback to InProgress
  • Assignee changed from S ET to Matthias Van Ceulebroeck
  • Target version set to 4.10.3

Thank you for the example.

I was able to quickly determine the root cause! The fix will be included in the next release.

Actions
Copy link
 #4

Updated by Matthias Van Ceulebroeck 11 months ago

  • Status changed from InProgress to Review
  • Assignee deleted (Matthias Van Ceulebroeck)
Actions
Copy link
 #5

Updated by Matthias Van Ceulebroeck 11 months ago

  • Assignee set to Korneel Dumon
Actions
Copy link
 #6

Updated by Matthias Van Ceulebroeck 11 months ago

  • Target version changed from 4.10.3 to 4.11.0
Actions
Copy link
 #7

Updated by Korneel Dumon 11 months ago

  • Status changed from Review to Resolved
  • Assignee changed from Korneel Dumon to Matthias Van Ceulebroeck
Actions
Copy link
 #8

Updated by Korneel Dumon 10 months ago

  • Status changed from Resolved to InProgress
Actions
Copy link
 #9

Updated by Matthias Van Ceulebroeck 10 months ago

  • Status changed from InProgress to Review
  • Assignee deleted (Matthias Van Ceulebroeck)
Actions
Copy link
 #10

Updated by Matthias Van Ceulebroeck 10 months ago

  • Assignee set to Korneel Dumon
Actions
Copy link
 #11

Updated by Matthias Van Ceulebroeck 9 months ago

  • Status changed from Review to Implemented @Emweb
  • Assignee changed from Korneel Dumon to Matthias Van Ceulebroeck
  • Target version changed from 4.11.0 to 4.10.4
Actions
Copy link
 #12

Updated by Apivan Tuntakurn 9 months ago 

diff --git a/src/web/DomElement.C b/src/web/DomElement.C
index 13bccc09..1d7ed351 100644
--- a/src/web/DomElement.C
+++ b/src/web/DomElement.C
@@ -135,7 +135,7 @@ std::string cssCamelNames_[] =
     "border-collapse",
     "pageBreakBefore", "pageBreakAfter",
     "zoom", "visibility", "display",
-    "boxSizing", "flex", "flexFlow", "alignSelf", "justifyContent"
+    "boxSizing", "flex", "flexDirection" , "flexFlow", "alignSelf", "justifyContent"
   };

 const std::string unsafeChars_ = " $&+,:;=?@'\"<>#%{}|\\^~[]`/";
Actions
Copy link
 #13

Updated by S ET 9 months ago

Now it's working as expected in 4.10.4. Thank you.

Actions
Copy link
 #14

Updated by Matthias Van Ceulebroeck 4 months ago

  • Status changed from Implemented @Emweb to Closed
  • % Done changed from 0 to 100
Actions
Copy link

Also available in: Atom PDF