Project

General

Profile

Actions

Bug #13075

closed

Large popup menus go off screen at the top

Added by Stephan Ehlers 7 months ago. Updated 13 days ago.

Status:
Closed
Priority:
Normal
Target version:
Start date:
10/02/2024
Due date:
% Done:

100%

Estimated time:

Description

If a popup menu (e.g. a context menu on some UI element) is large enough but not larger than the available total space (usually the window height), it can be placed in such a way that its top goes off screen.

"Large enough" in this case means that the menu is too large to be displayed "hanging" off the mouse cursor without cutting off its bottom, yet also too large to be shown above the current cursor position. The current algorithm only checks for the former case.

I created a PR on github (https://github.com/emweb/wt/pull/220) to fix this issue; it is currently based on 4.10.4, but could easily be rebased to 4.11.0.

Actions #1

Updated by Stephan Ehlers 7 months ago

To add some numbers to the example:
Imagine a context menu that is 51% as tall as the screen, and you want to open it exactly at the center of the screen. It will be displayed above the cursor, since there is not enough space below it. But then the top 1% of the menu will be cut off.

Actions #2

Updated by Matthias Van Ceulebroeck 7 months ago

  • Target version set to 4.11.1

Thank you for the submission Stephan.
I will soon review the implementation and test it, to see if I can find any edge cases to it.

Actions #3

Updated by Matthias Van Ceulebroeck 6 months ago

  • Target version changed from 4.11.1 to 4.11.3
Actions #4

Updated by Matthias Van Ceulebroeck 2 months ago

  • Target version changed from 4.11.3 to 4.11.4
Actions #5

Updated by Matthias Van Ceulebroeck about 1 month ago

  • Status changed from New to InProgress
  • Assignee changed from Stephan Ehlers to Romain Mardulyn
Actions #6

Updated by Matthias Van Ceulebroeck about 1 month ago

  • Status changed from InProgress to Review
  • Assignee changed from Romain Mardulyn to Matthias Van Ceulebroeck
Actions #7

Updated by Matthias Van Ceulebroeck about 1 month ago

  • Status changed from Review to Implemented @Emweb
  • Assignee changed from Matthias Van Ceulebroeck to Romain Mardulyn
  • % Done changed from 80 to 100
Actions #8

Updated by Matthias Van Ceulebroeck 24 days ago

  • Status changed from Implemented @Emweb to Implemented @Test
Actions #9

Updated by Matthias Van Ceulebroeck 13 days ago

  • Status changed from Implemented @Test to Closed
Actions

Also available in: Atom PDF