Improvements #13661: Eliminate some deprecated warnings in Wt/Date when building with Clang 20.1 - Wt - Redmine

Actions

Copy link

Improvements #13661

open

Eliminate some deprecated warnings in Wt/Date when building with Clang 20.1

Added by Stefan Bn 4 months ago. Updated 6 days ago.

Status:

Review

Priority:

Normal

Assignee:

Target version:

4.12.2

Start date:

03/19/2025

Due date:

% Done:

Estimated time:

Description

Current version of Clang 20.1 generates several deprecated warnings in ./include/Wt/Date/include/date/date.h when compiling with Wt.

These can be fixed easily by just removing the particular whitespaces - see patch attached.

In file included from D:/Dev/WebLibs/wt-lib-64/include/Wt/Date/include/date/tz.h:99:
D:/Dev/WebLibs/wt-lib-64/include/Wt/Date/include/date/date.h:966:34: warning: identifier '_d' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
  966 | CONSTCD11 date::day  operator "" _d(unsigned long long d) NOEXCEPT;
      |                      ~~~~~~~~~~~~^~
      |                      operator""_d
D:/Dev/WebLibs/wt-lib-64/include/Wt/Date/include/date/date.h:967:34: warning: identifier '_y' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
  967 | CONSTCD11 date::year operator "" _y(unsigned long long y) NOEXCEPT;
      |                      ~~~~~~~~~~~~^~
      |                      operator""_y
D:/Dev/WebLibs/wt-lib-64/include/Wt/Date/include/date/date.h:1975:13: warning: identifier '_d' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
 1975 | operator "" _d(unsigned long long d) NOEXCEPT
      | ~~~~~~~~~~~~^~
      | operator""_d
D:/Dev/WebLibs/wt-lib-64/include/Wt/Date/include/date/date.h:1983:13: warning: identifier '_y' preceded by whitespace in a literal operator declaration is deprecated [-Wdeprecated-literal-operator]
 1983 | operator "" _y(unsigned long long y) NOEXCEPT
      | ~~~~~~~~~~~~^~
      | operator""_y

Thanks!
Stefan

Files

date_h.patch (1 KB) date_h.patch

Stefan Bn, 03/19/2025 10:30 PM

Actions

Copy link

Updated by Matthias Van Ceulebroeck 3 months ago

Target version set to 4.12.2

Actions

Copy link

Updated by Romain Mardulyn about 2 months ago

Status changed from New to InProgress
Assignee set to Romain Mardulyn

Actions

Copy link

Updated by Romain Mardulyn about 2 months ago

Status changed from InProgress to Review
Assignee deleted (~~Romain Mardulyn~~)

Actions

Copy link

Updated by Stefan Bn 6 days ago

In addition: Wt 4.12.0 introduces some new warnings:

[150/432] Building CXX object src/CMakeFiles/wt.dir/Wt/WPasswordEdit.C.obj
In file included from D:/Dev/BuildLibs/wt/wt-4.12.0/src/Wt/WPasswordEdit.C:9:
D:/Dev/BuildLibs/wt/wt-4.12.0/src/Wt/WPasswordEdit.h:147:39: warning: 'realValidator' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
  147 |   virtual std::shared_ptr<WValidator> realValidator() const { return WLineEdit::validator(); }
      |                                       ^
D:/Dev/BuildLibs/wt/wt-4.12.0/src/Wt/WFormWidget.h:195:39: note: overridden virtual function is here
  195 |   virtual std::shared_ptr<WValidator> realValidator() const { return validator(); }
      |                         

[412/432] Building CXX object src/http/CMakeFiles/wthttp.dir/Request.C.obj
D:/Dev/BuildLibs/wt/wt-4.12.0/src/http/Request.C:26:9: warning: 'HAVE_STRCASECMP' macro redefined [-Wmacro-redefined]
   26 | #define HAVE_STRCASECMP
      |         ^
<command line>:16:9: note: previous definition is here
   16 | #define HAVE_STRCASECMP 1
      |         ^
D:/Dev/BuildLibs/wt/wt-4.12.0/src/http/Request.C:27:9: warning: 'HAVE_STRNCASECMP' macro redefined [-Wmacro-redefined]
   27 | #define HAVE_STRNCASECMP
      |         ^
<command line>:17:9: note: previous definition is here
   17 | #define HAVE_STRNCASECMP 1
      |         ^

Actions

Copy link

Also available in: Atom PDF

Project

General

Profile

Wt