Project

General

Profile

Actions

Bug #13740

open

Wt::Auth::OAuthRedirectEndpoint: possible concurrency issues

Added by Dries Mys 6 months ago. Updated 14 days ago.

Status:
Implemented @Emweb
Priority:
Normal
Target version:
Start date:
05/15/2025
Due date:
% Done:

100%

Estimated time:

Description

Normally, each Wt::Auth::OAuthRedirectEndpoint object will not receive multiple requests simultaneously. However, in rare cases (e.g. in case of connectivity issues), multiple redirects may be received simultaneously. This may result in a crash, as the Wt::Auth::OAuthRedirectEndpoint::handleRequest does not seem to be implemented in a thread safe manner. E.g. handleRequest calls OAuthProcess::requestToken, which destructed the previous Http::Client. Hence, while one thread is still executing the Http::Client::post method, another thread may already destruct the client.

Possible solutions

  • Use proper locking while accessing the OAuthProcess object.
  • Use setTakesUpdateLock to avoid concurrency issues. In the non-popup mode, this should be reasonable, but in case of a popup is used, locking the application may be undesired.
Actions #1

Updated by Matthias Van Ceulebroeck 6 months ago

  • Target version set to 4.12.2

Thanks for the submission, Dries.

I indeed think me way require a custom lock, not the WApplication::UpdateLock, as blocking the UI for a prolonged amount of time may not be desired.

Actions #2

Updated by Romain Mardulyn 5 months ago

  • Status changed from New to InProgress
  • Assignee set to Romain Mardulyn
Actions #3

Updated by Romain Mardulyn 5 months ago

  • Status changed from InProgress to Review
  • Assignee deleted (Romain Mardulyn)
Actions #4

Updated by Matthias Van Ceulebroeck 19 days ago

  • Assignee set to Matthias Van Ceulebroeck
Actions #5

Updated by Matthias Van Ceulebroeck 14 days ago

  • Status changed from Review to Implemented @Emweb
  • Assignee changed from Matthias Van Ceulebroeck to Romain Mardulyn
  • % Done changed from 0 to 100
Actions

Also available in: Atom PDF