Bug #1987: WPushButton theme-provided style class is lost when user modifies styleClass after initial render - Wt - Redmine

Actions

Copy link

Bug #1987

closed

WPushButton theme-provided style class is lost when user modifies styleClass after initial render

Added by Bruce Toll over 11 years ago. Updated over 11 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Koen Deforche

Target version:

3.3.1

Start date:

06/17/2013

Due date:

% Done:

Estimated time:

Description

With the Bootstrap theme, Wt automatically adds a "btn" class when rendering a WPushButton. However, this "btn" class is lost if user code does an addStyleClass after the initial render, e.g. to highlight a button with "btn-info" or one of the other Bootstrap styles. This issue is demonstrated with button 1 in the attached test program. A possible work-around is for user code to setStyleClass with all necessary user style classes along with a "btn" class. This issue was found in the current git version 3.3.0-16-gacad52e.

I've also attached a patch that seems to help with this issue.

Files

Download all files

lost_pushbutton_style_20130616a.cc (2.75 KB) lost_pushbutton_style_20130616a.cc		Bruce Toll, 06/17/2013 09:18 PM
lost_pushbutton_style_fix1_20130617a.diff (531 Bytes) lost_pushbutton_style_fix1_20130617a.diff		Bruce Toll, 06/17/2013 09:18 PM

Actions

Copy link

Updated by Koen Deforche over 11 years ago

Status changed from New to InProgress
Assignee set to Koen Deforche
Target version set to 3.3.1

Hey Bruce,

Duh. This is something that got totally overlooked when implementing theme support.

I can see how your patch works, but am reflecting on other ways out of this.

Thanks!

Regards,

koen

Actions

Copy link