Project

General

Profile

Actions
Copy link

Bug #2833

closed
CD WD

http::server::buffer_string::icontains link error with WT 3.3.2

Bug #2833: http::server::buffer_string::icontains link error with WT 3.3.2

Added by Cynthia Donato over 12 years ago. Updated over 12 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Wim Dumon
Target version:
-
Start date:
03/20/2014
Due date:
% Done:

0%

Estimated time:

Description

hello,

I was previously using wt 3.2.3 for development of an application. I just switched over to wt3.3.2 and am now experienceing the following link error:

error LNK2019: unresolved external symbol __imp_StrStrIA referenced in function "public: bool __cdecl http::server::buffer_string::icontains(char const *)const " (?icontainsbuffer\_string@server@http@@QEBA\_NPEBDZ)

Any guidance as to how to resolve this issue would be greatly appreciated.

Thanks

EM Updated by Eivind Midtgård over 12 years ago Actions
Copy link
 #1

You need to link with shlwapi.lib

Regards,
Eivind

CD Updated by Cynthia Donato over 12 years ago Actions
Copy link
 #2

thank you that fixed the issue.

Much appreciated :)

KD Updated by Koen Deforche over 12 years ago Actions
Copy link
 #3

  • Status changed from New to InProgress
  • Assignee set to Wim Dumon
  • Target version set to 3.3.3

Is this something we should add in the linking of wthttpd?

KD Updated by Koen Deforche over 12 years ago Actions
Copy link
 #4

  • Target version deleted (3.3.3)

CD Updated by Cynthia Donato over 12 years ago Actions
Copy link
 #5

Adding the shlwapi.lib to my qmake file solved the issue. I believe it should be added to the linking of the wthttpd but in my case it's not a show stopper.

EM Updated by Eivind Midtgård over 12 years ago Actions
Copy link
 #6

Why not use boost::icontains and boost::iequals instead of strcasestr and strcasecmp?

WD Updated by Wim Dumon over 12 years ago Actions
Copy link
 #7

The reason why we changed it is performance. This should be a pure ASCII strstr, so locales don't matter.

BR,
Wim.

BS Updated by Boris Savelev over 12 years ago Actions
Copy link
 #8

Wim Dumon wrote:

The reason why we changed it is performance. This should be a pure ASCII strstr, so locales don't matter.

BR,
Wim.

Hello!
Using `strcasestr` will brake compilation on Solaris (Solaris haven't strcasestr)

WD Updated by Wim Dumon over 12 years ago Actions
Copy link
 #9

  • Status changed from InProgress to Resolved

since these functions cause such headaches, I modified the code to use boost methods unless we know they exist. Their existance is tested by cmake.

The 'performance issue' is not really an issue after all, only makes Wt better for benchmarks.

Wim.

KD Updated by Koen Deforche over 12 years ago Actions
Copy link
 #10

  • Status changed from Resolved to Closed
Actions
Copy link

Also available in: PDF Atom