Project

General

Profile

Actions

Improvements #12384

open

Make the Boost::spirit parser for WMessageResources plurals more robust

Added by Matthias Van Ceulebroeck 4 months ago. Updated 4 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Target version:
Start date:
02/05/2024
Due date:
% Done:

0%

Estimated time:

Description

There were already edge-cases found in this parser (by OSS-Fuzz). Resolving some of these isn't straighforward. A better approach would be to rewrite this parser.
Alternatives are Boost Spirit (V2 & Qi), or even Boost Spirit x3. This is however not the easiest code to work with, and will take some time.


Related issues 1 (0 open1 closed)

Related to Bug #12374: Resolve an overflow with the Boost spirit grammar implementation for message resource pluralsClosedMatthias Van Ceulebroeck01/31/2024

Actions
Actions #1

Updated by Matthias Van Ceulebroeck 4 months ago

  • Related to Bug #12374: Resolve an overflow with the Boost spirit grammar implementation for message resource plurals added
Actions #2

Updated by Christian Meyer 4 months ago

If you are already in that part of the code, maybe you could add multiple plural definitions?

That would help to keep all Plural cases of a language within one file

See https://redmine.emweb.be/boards/2/topics/18391

Actions #3

Updated by Matthias Van Ceulebroeck 4 months ago

I will take this into account when rewriting this. This does entail some more changes, so I'm not quite positive that this can be arranged attached to this issue.
Regardless, I will take a look at it.

Actions

Also available in: Atom PDF