Bug #1821
closedLayout issue with Firefox
0%
Description
I'm trying to create a layout with a fixed header, followed by two columns separated with a resizer, followed by a footer. The footer should be located at the end of the longer column and my goal in using layout is to provide a resizer and to extend the shorter column to reach the footer (for styling).
The approach was initially based on the NestedLayout.cpp example in Wt and works as expected on a number of browsers including IE 10, Chrome 26.0.1410.43m and Safari (iPad). However, it does not extend the right-hand column on Firefox 20, when the initial layout has a left hand column that is taller than the right hand column (or that's how it seems).
To demonstrate the issue, I have attached a modified version of the Wt NestedLayout.cpp example, which includes instructions. Given that I am new to Wt, it is entirely possible that there is a bug in my sample code and that the behavior with the other browsers is unintentional. Is there a better way to achieve the desired effect with Wt?
This issue was found to exist in 3.2.3 and on the github version 3.3.0-rc4-10-gff44b56.
Thanks for all the great work on Wt!
Files
Updated by Koen Deforche over 11 years ago
- Status changed from New to InProgress
- Assignee set to Koen Deforche
- Target version set to 3.3.1
Updated by Koen Deforche over 11 years ago
- Status changed from InProgress to Resolved
Hey,
So apparently Firefox wanted to improve their loading/blocking behaviour (See https://bugzilla.mozilla.org/show_bug.cgi?id=792438) but skrewed up on the way. For some reason the Script tag is now blocked by CSS.
I've fixed this with a workaround specifically for Firefox 20 or later. You can probably easily backport this fix to previous versions.
They are the changes in Boot.js and Boot.min.js from this commit : https://github.com/kdeforche/wt/commit/0bc03dacfbed84e055838e6971c802e0781854e5
Regards,
koen
Updated by Bruce Toll over 11 years ago
Hi Koen,
Thanks for addressing the tricky problem with Firefox 20.0. I think your resolution was intended for issue #1828, though. At this time, I believe the layout issue with Firefox referenced in this report still exists. If that's the case, could you update the status on this issue.
Thanks!
Bruce
Updated by Wim Dumon over 11 years ago
Hi Bruce,
Did you retest? These issues are closely interrelated so your issue may be solved...
BR,
Wim.
Updated by Bruce Toll over 11 years ago
Hi Wim,
Thanks for following-up. I had retested my application, after Koen's update, and the Firefox layout problem persisted. After your note, I retested with the attached test program and verified that it also continues to demonstrate the problem. For the record, I used the github Wt 3.3.0-3-g3cd28b4 for these latest tests.
Thanks for your help and let me know if I can provide any additional information.
Regards,
Bruce
Updated by Bruce Toll over 11 years ago
Hi! Some additional information: the attached test program also fails with an older version of Firefox --- Debian Wheezy Iceweasel 10.0.12. I believe that the problem may be due to how Firefox handles scrollHeight. I found a workaround that helps with my application --- and the attached test program. I'm not sure that this is a complete solution or that it won't cause regressions for other programs. In any case, it's a 5-line patch, which will hopefully be of some use. Please see: https://github.com/kdeforche/wt/pull/26/files
Regards,
Bruce
Updated by Koen Deforche over 11 years ago
Hey,
I've based myself on your pull request to fix this issue, but made it apply more specifically to Firefox and also made sure it didn't affect cases where a height has been set.
Thanks a lot !
Regards,
koen
Updated by Koen Deforche over 11 years ago
- Status changed from Resolved to Closed