Project

General

Profile

Actions

Bug #1864

closed

AppRoot in examples

Added by Pau Garcia i Quiles over 11 years ago. Updated over 11 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Target version:
Start date:
04/23/2013
Due date:
% Done:

0%

Estimated time:

Description

The widgetgallery example uses its own 'approot' directory under examples/widgetgallery/approot.

The rest of the examples use the example directory (e. g. examples/blog) as the approot directory.

This consistency causes examples/run-examples.cmake and examples/run-examples.bat.cmake to generate the right script in all cases but in widgetgallery.

Given that Wt now supports the "---approot" argument, I think it would be better if an 'approot' directory be created for every example and the support files would be moved there.

The same happens with 'docroot': widgetgallery contains a 'docroot' directory, the rest of the examples do not. The script generated by configuring run-examples.cmake and run-examples.bat.cmake to fail in the widgetgallery example for this reason.

Actions #1

Updated by Pau Garcia i Quiles over 11 years ago

I can do the lifting in my fork in github if you agree with this change.

Actions #2

Updated by Wim Dumon over 11 years ago

Hi Pau,

In my opinion, this is a good idea.

Wim.

Actions #3

Updated by Pau Garcia i Quiles over 11 years ago

I have resolved this in an alternative way (make CMake look for approot/docroot folders and use them if they exist).

I created GitHub pull request #28 with the solution

https://github.com/kdeforche/wt/pull/28

Actions #4

Updated by Pau Garcia i Quiles over 11 years ago

I have updated my pull request:

https://github.com/kdeforche/wt/pull/32

Actions #5

Updated by Koen Deforche over 11 years ago

  • Status changed from New to Resolved
  • Assignee set to Koen Deforche
  • Target version set to 3.3.1

Hey Pau,

Thanks!

Regards,

koen

Actions #6

Updated by Koen Deforche over 11 years ago

  • Status changed from Resolved to Closed
Actions

Also available in: Atom PDF