Bug #1864
closedAppRoot in examples
0%
Description
The widgetgallery example uses its own 'approot' directory under examples/widgetgallery/approot.
The rest of the examples use the example directory (e. g. examples/blog) as the approot directory.
This consistency causes examples/run-examples.cmake and examples/run-examples.bat.cmake to generate the right script in all cases but in widgetgallery.
Given that Wt now supports the "---approot" argument, I think it would be better if an 'approot' directory be created for every example and the support files would be moved there.
The same happens with 'docroot': widgetgallery contains a 'docroot' directory, the rest of the examples do not. The script generated by configuring run-examples.cmake and run-examples.bat.cmake to fail in the widgetgallery example for this reason.
Updated by Pau Garcia i Quiles over 11 years ago
I can do the lifting in my fork in github if you agree with this change.
Updated by Wim Dumon over 11 years ago
Hi Pau,
In my opinion, this is a good idea.
Wim.
Updated by Pau Garcia i Quiles over 11 years ago
I have resolved this in an alternative way (make CMake look for approot/docroot folders and use them if they exist).
I created GitHub pull request #28 with the solution
Updated by Pau Garcia i Quiles over 11 years ago
I have updated my pull request:
Updated by Koen Deforche over 11 years ago
- Status changed from New to Resolved
- Assignee set to Koen Deforche
- Target version set to 3.3.1
Hey Pau,
Thanks!
Regards,
koen
Updated by Koen Deforche over 11 years ago
- Status changed from Resolved to Closed